Skip to content

Commit

Permalink
Log and return zero val objects on CtorArgs
Browse files Browse the repository at this point in the history
  • Loading branch information
anuptalwalkar committed May 23, 2017
1 parent c4b8754 commit 4bf24e3
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 3 deletions.
10 changes: 8 additions & 2 deletions container_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -415,8 +415,14 @@ func TestInvokeFailureUnresolvedDependencies(t *testing.T) {
err = c.Invoke(func(p1 *Parent1) {})
require.Contains(t, err.Error(), "unable to resolve *dig.Parent1")

err = c.Invoke(func(p12 *Parent12) {})
require.Contains(t, err.Error(), "dependency of type *dig.Parent12 is not registered")
var zeroP12 *Parent12
err = c.Invoke(func(p12 *Parent12) {
zeroP12 = p12
})
require.NoError(t, err)
newZeroP12, ok := reflect.Zero(reflect.TypeOf(zeroP12)).Interface().(*Parent12)
require.True(t, ok)
assert.Equal(t, zeroP12, newZeroP12)
}

func TestProvide(t *testing.T) {
Expand Down
4 changes: 3 additions & 1 deletion internal/graph/graph.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ package graph
import (
"bytes"
"fmt"
"log"
"reflect"

"github.com/pkg/errors"
Expand Down Expand Up @@ -204,7 +205,8 @@ func (g *Graph) ConstructorArguments(ctype reflect.Type) ([]reflect.Value, error
}
args[idx] = v
} else {
return nil, fmt.Errorf("%v dependency of type %v is not registered", ctype, arg)
log.Printf("Assigning zero value for arguments in %v. Dependency of type %v is not yet registered", ctype, arg)
args[idx] = reflect.Zero(arg)
}
}
return args, nil
Expand Down
14 changes: 14 additions & 0 deletions internal/graph/graph_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,20 @@ func TestResolvedArguments(t *testing.T) {
assert.Equal(t, reflect.TypeOf(values[1].Interface()).String(), "*graph.Parent12")
}

func Test_UnprovidedConstructorArguments(t *testing.T) {
t.Parallel()
g := NewGraph()

values, err := g.ConstructorArguments(reflect.TypeOf(constructor))
require.NoError(t, err)

assert.Equal(t, reflect.TypeOf(values[0].Interface()).String(), "*graph.Parent1")
assert.Equal(t, reflect.TypeOf(values[1].Interface()).String(), "*graph.Parent12")

assert.Equal(t, values[0], reflect.Zero(reflect.TypeOf(values[0].Interface())))
assert.Equal(t, values[1], reflect.Zero(reflect.TypeOf(values[1].Interface())))
}

func TestGraphString(t *testing.T) {
g := NewGraph()
p1 := &Parent1{
Expand Down

0 comments on commit 4bf24e3

Please sign in to comment.