Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README examples #1

Closed
glibsm opened this issue Mar 23, 2017 · 3 comments
Closed

update README examples #1

glibsm opened this issue Mar 23, 2017 · 3 comments
Assignees

Comments

@glibsm
Copy link
Collaborator

glibsm commented Mar 23, 2017

Need to take a pass. Includes things like:

err := dig.Resolve(&o) // notice the pointer to a pointer as param type
if err == nil {
    // o is ready to use
}
err = g.Resolve(&f1)
require.NoError(t, err)
@glibsm
Copy link
Collaborator Author

glibsm commented Mar 23, 2017

It would be ideal to illustrate an example of an actual graph. Something like:

Type1 -> Type2, Type3
Type2 -> Type4
Type3 -> Type5
Type4 -> Type6, Type7

Much like what's in the test, but a more realistic example.

@HelloGrayson HelloGrayson self-assigned this Mar 23, 2017
@HelloGrayson
Copy link
Contributor

I'll take this one 🥇

@glibsm
Copy link
Collaborator Author

glibsm commented Apr 28, 2017

Closing via #22
We can make further improvements as necessary (i still think some diagrams are helpful)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants