Add test for multi-return constructor being called once #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a similar test, but it doesn't cover the multi-return scenario. Just want to make sure we don't accidentally break this while migrating the map to a composite key in the future
| @@ -212,6 +212,27 @@ func TestEndToEndSuccess(t *testing.T) { | |||
| require.NoError(t, c.Invoke(consumer), "invoke failed") | |||
| }) | |||
|
|
|||
| t.Run("multiple-type constructor is called once", func(t *testing.T) { | |||
There was a problem hiding this comment.
Can you add test for func() (*A, *A, error) as well?
anuptalwalkar
approved these changes
May 30, 2017
abhinav
pushed a commit
that referenced
this pull request
Jun 1, 2017
There is a similar test, but it doesn't cover the multi-return scenario. Just want to make sure we don't accidentally break this while migrating the map to a composite key in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It passes as-is, but covers an important case.
There is a similar test for counting a single-return constructor.
Just want to make sure we don't accidentally break this while migrating
the map to a composite key in the future