Add edge tests around Provide and Invoke #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
@anuptalwalkar can you add something to the PR description for more context? |
abhinav
reviewed
May 31, 2017
| constructor := func() (*A, *A, error) { | ||
| return &A{}, &A{}, nil | ||
| } | ||
| require.Error(t, c.Provide(constructor), "provide failed") |
There was a problem hiding this comment.
I think this particular test function has only success cases (EndToEndSuccess). Perhaps move this out to a different test.
There was a problem hiding this comment.
good point. I will move it out.
anuptalwalkar
force-pushed
the
anup-dig-behavior-tests
branch
from
8588c6c
to
cc8c6a3
Compare
glibsm
approved these changes
May 31, 2017
abhinav
pushed a commit
that referenced
this pull request
Jun 1, 2017
* rebase for conflicts * moved failure tests into its own test
hbdf
pushed a commit
to hbdf/dig
that referenced
this pull request
Jul 14, 2022
hbdf
pushed a commit
to hbdf/dig
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some missing edge cases around provide -