param: Pointers are not parameter objects #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glibsm
approved these changes
Jun 1, 2017
akshayjshah
approved these changes
Jun 1, 2017
| @@ -357,12 +354,12 @@ func (c *Container) createParamObject(t reflect.Type) (reflect.Value, error) { | |||
| case "true", "yes": | |||
There was a problem hiding this comment.
Side question: why are we supporting both of these values? If we want to support multiple values, why don't we just use strconv.ParseBool and accept all the usual truthy strings?
There was a problem hiding this comment.
Good call. Will change in a different PR.
This narrows down the definition of parameter objects to only structs embedding `dig.Param`. Pointers to structs embedding `dig.Param` are treated like any other struct pointer.
hbdf
pushed a commit
to hbdf/dig
that referenced
this pull request
Jul 14, 2022
hbdf
pushed a commit
to hbdf/dig
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #81. Will land as a separate commit on dev once #73 lands.