Only allow constructors #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in #74, Provide should only take constructors. This not only cleans up some of dig's internals, but also removes a few ambiguous cases: providing interfaces (e.g., Tally scopes) and functions now works exactly the same as providing other types. (Before, they behaved oddly - functions were assumed to be constructors, and providing an interface instance would instead provide the concrete type.)
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 96.25% 96.83% +0.58%
==========================================
Files 3 3
Lines 267 253 -14
==========================================
- Hits 257 245 -12
+ Misses 7 6 -1
+ Partials 3 2 -1
Continue to review full report at Codecov.
|
glibsm
approved these changes
Jun 11, 2017
hbdf
pushed a commit
to hbdf/dig
that referenced
this pull request
Jul 14, 2022
This enforces the canonical import path and should reduce confusion in the future. https://golang.org/cmd/go/#hdr-Import_path_checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #74, Provide should only take constructors. This not
only cleans up some of dig's internals, but also removes a few ambiguous
cases: providing interfaces (e.g., Tally scopes) and functions now works
exactly the same as providing other types. (Before, they behaved oddly -
functions were assumed to be constructors, and providing an interface
instance would instead provide the concrete type.)