Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScopedProvider perf optimization #167

Closed
shawnburke opened this issue Jan 13, 2017 · 2 comments
Closed

ScopedProvider perf optimization #167

shawnburke opened this issue Jan 13, 2017 · 2 comments

Comments

@shawnburke
Copy link
Contributor

This guy should probably have a map or something to memoize search results.

https://github.com/uber-go/fx/blob/master/config/provider.go#L58

Might need to also watch change notifications from any memoize'd keys or parents.
@ghost
Copy link

ghost commented Jan 13, 2017

Why do you think it should be done on the ScopedProvider level, not Provider? Like yaml https://github.com/uber-go/fx/blob/master/config/yaml.go#L148
And yes, we have a bug on change callback, it should include scope key(GFM-290)

@ghost
Copy link

ghost commented May 15, 2017

We don't have a scope anymore and introduced a wrapper that caches results, which is used in the YAML provider

@ghost ghost closed this as completed May 15, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shawnburke