Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename stdlibErr to stdliberr or stderr #234

Closed
yutongp opened this issue Feb 10, 2017 · 2 comments
Closed

Rename stdlibErr to stdliberr or stderr #234

yutongp opened this issue Feb 10, 2017 · 2 comments
Assignees

Comments

@yutongp
Copy link
Contributor

yutongp commented Feb 10, 2017

for https://github.com/uber-go/fx/blob/master/ulog/log.go#L24

package-names: "Good package names are short and clear. They are lower case, with no under_scores or mixedCaps."

I like this convention because I know package names are all lower case so I can seperate them from private struct defined somewhere else. I think this convention applies to rename package as well.

So maybe 'stdliberr' or 'stderr'?

@ascandella
Copy link
Contributor

@alsamylkin

@ascandella ascandella assigned ascandella and ghost Feb 10, 2017
@ghost
Copy link

ghost commented Feb 10, 2017

#235

@ghost ghost closed this as completed Feb 10, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants