Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Manager.Start to Manager.Run, and Manager.StartAsync to Manager.Start? #321

Closed
bufdev opened this issue Feb 23, 2017 · 1 comment
Closed

Rename Manager.Start to Manager.Run, and Manager.StartAsync to Manager.Start? #321

bufdev opened this issue Feb 23, 2017 · 1 comment

Comments

@bufdev
Copy link
Contributor

bufdev commented Feb 23, 2017

Might be nice. Note this will break like everyone's usage of FX right now, so not so nice. Point being, Start isn't really just starting it, I want it to be clear that it's blocking from the name. Serve might also work.
@ascandella
Copy link
Contributor

Can you use our internal feedback instructions? Split brain between JIRA and GH issues means we likely will miss or misprioritize these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ascandella @bufdev