-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register
function name is overused
#432
Comments
What makes this confusing? Each function is in the context of its own package (dig/task/dispatcher), has different arguments. It should be clear to the user from context/arguments/comments what it's doing. |
I suggest renaming
|
I see. Register seems that way to me - a user is registering a type or constructor with the container, so that the object graph can be built. |
Closing - the |
There are currently three usages of function
Register
which have entirely different applications:dig.Register
inserts into the dependency graph.task.Register
registers a function into the async task module, or an interface implementation.dispatcher.Register
registers[]transport.Procedure
for YARPC.Two out of the three are under UberFx control, one comes from YARPC.
An earlier suggestion was to rename
dig.Register
todig.Provide
. I am now in favor of the change to try and break up the overloaded word.The text was updated successfully, but these errors were encountered: