Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignores: Don't use strings.Contains #112

Merged
merged 1 commit into from
Oct 23, 2023
Merged

ignores: Don't use strings.Contains #112

merged 1 commit into from
Oct 23, 2023

Commits on Oct 23, 2023

  1. ignores: Don't use strings.Contains

    Instead of matching for built-in functions with strings.Contains,
    use the parsed stack information to match function names exactly.
    
    Following this change, the only remaining strings.Contains are
    to match on the goroutine state:
    
    ```
    % rg strings.Contains
    utils_test.go
    84:             if strings.Contains(s.State(), "run") {
    
    internal/stack/stacks_test.go
    249:            if strings.Contains(s.State(), "run") {
    ```
    
    Resolves #41
    abhinav committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    78c5017 View commit details
    Browse the repository at this point in the history