This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: I was having a hard time reasoning about the fieldHook function so I did some refactoring to make it easier to add the embedded struct fields. - Remove the in-place data value updates (this appears to have been an optimization, but, it's not necessary and make the code hard to reason about) - Extract getting the updates struct into it's own function. - Extract getting decodable Struct fields into it's own function. - Extract applying updates to the srcData into it's own function. - Rename variables to be more explicit - Don't use the `from` field, which should be equivalent to srcData.Type() Test Plan: tests pass
- Loading branch information
Will Hughes
committed
May 18, 2017
1 parent
003e700
commit eae9931
Showing
1 changed file
with
106 additions
and
91 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters