Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for anonymous struct returns #14

Closed
wants to merge 2 commits into from

Conversation

bjohnson-va
Copy link

@CLAassistant
Copy link

CLAassistant commented Jun 28, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sywhang sywhang requested a review from r-hang August 15, 2023 18:28
import (
reflect "reflect"

gomock "github.com/golang/mock/gomock"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the imports to the new go.uber.org/mock import path.

Value string
Nested struct {
Value int
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should anonymous structs with external types also be exercised? I see addImports implementation does not currently return anything.

@JacobOaks JacobOaks closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants