-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Allow updating the limit #69
Comments
Hi, Would you elaborate on the use case for this? Do you have a project already, or is it a theoretical interest? |
@rabbbit I am working on it and evaluating various rate limiters. This is inspired by https://github.com/Netflix/concurrency-limits and wanted to reuse any existing libraries if present. |
I read the go files in this repo, first way is the better way for this ratelimit, I think, because limit is not direct influence to this ratelimit |
@rabbbit If we update the perRequest value in |
It's not just perRequest. Since we also store slack, we'd need to update (or throw away?) the actual slack value. We'd also need to do it atomically, so there's extra complexity there. Is creating a new limiter feasible? If so, that would be my preference. |
@rabbbit sure, I don't see any concerns with it, at worst case scenario we'd be creating a new object every couple of seconds till we hit a stable point. You see any concerns with that? |
@rabbbit BTW I'm implementing Vegas congestion control on top of this library. |
If it works for you, please go that way then :)
…On Wed, 17 Mar 2021 at 11:37, Prathik Rajendran M ***@***.***> wrote:
@rabbbit <https://github.com/rabbbit> BTW I'm implementing Vegas
congestion control on top of this library.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#69 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACG3UWWUSNWFZAH5BFO57TTEDEBXANCNFSM4YMSQIRQ>
.
|
Goal: To use this library with an adaptive rate limiter algorithm like Vegas or AIMD
Problem: Right now the library exposes no way to update the rates dynamically.
There are two ways to solve for this
Would like feedback on which is the preferred approach. Or if there is any other way.
The text was updated successfully, but these errors were encountered: