Run tests on the latest 2 go versions, update go directive in go.mod #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 159 159
=========================================
Hits 159 159 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rabbbit
added a commit
that referenced
this pull request
Jul 9, 2023
I do wonder whether #111 is failing due to bad caching we have.
rabbbit
added a commit
that referenced
this pull request
Jul 9, 2023
I do wonder whether #111 is failing due to the caching we might have (?) Based on https://github.com/uber-go/zap/blob/master/.github/workflows/go.yml
rabbbit
added a commit
that referenced
this pull request
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support latest two versions, we should be testing on them.
Go directive shouldn't change much, I'm updating it just to be in sync. We're still pre Go 1.21 so this should not affect the users.