Fix error use of internal package #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using ratelimit with go mod, it complaints of using internal module. Reason is use of internal modules is not permitted from outside dep projects/packages. e.g. ./../../../pkg/mod/github.com/uber-go/ratelimit@v0.1.0/ratelimit.go:27:2: use of internal package go.uber.org/ratelimit/internal/clock not allowed Hence, renaming the internal folder to central to avoid this failure using go mod. Signed-off-by: Aliasgar Ginwala <aginwala@ebay.com>
|
|
|
Please import the package as |
|
Thanks for the suggestion. I cleared my go.mod entries for uber-go and used go.uber.org/ratelimit. It works fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ratelimit with go mod, it complaints of using internal module.
Reason is use of internal modules is not permitted from outside dep projects/packages.
e.g. ./../../../pkg/mod/github.com/uber-go/ratelimit@v0.1.0/ratelimit.go:27:2:
use of internal package go.uber.org/ratelimit/internal/clock not allowed
Hence, renaming the internal folder to central to avoid this failure using go mod.
Signed-off-by: Aliasgar Ginwala aginwala@ebay.com