Run tests on all (two) implementations #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test runner will simply execute all tests on all implementations. This is so that we can: - make sure both implementations are equivalent - start adding more implementations - have proper test coverage, yay. The diff is slightly bigger than the actual changes: - I'm modifying the tests to run in the same package as the code, so that I have access to each of the implementations. - I'm renaming `runner` to `testRunner` since benchmark defines it's own runner. I considered somehow keeping the `ratelimit_test` package, and also having a separate `ratelimit` tests to just test implementations but that feels too complicated for the benefit - lets keep it simple and just have a single set of tests. We could probably also make the benchmark tests re-use the same test runner, but that's a separate follow up.
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
============================================
+ Coverage 65.07% 100.00% +34.92%
============================================
Files 3 3
Lines 63 63
============================================
+ Hits 41 63 +22
+ Misses 22 0 -22
Continue to review full report at Codecov.
|
Merged
rabbbit
changed the title
abhinav
approved these changes
Jan 15, 2021
|
thanks @abhinav. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test runner will simply execute all tests on all implementations.
This is so that we can:
The diff is slightly bigger than the actual changes:
so that I have access to each of the implementations.
runnertotestRunnersince benchmark defines it'sown runner.
I considered somehow keeping the
ratelimit_testpackage,and also having a separate
ratelimittests to just testimplementations but that feels too complicated for the benefit - lets
keep it simple and just have a single set of tests.
We could probably also make the benchmark tests re-use the same test runner,
but that's a separate follow up.