Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support #1000

Open
abhinav opened this issue Sep 7, 2021 · 0 comments
Open

Windows support #1000

abhinav opened this issue Sep 7, 2021 · 0 comments
Assignees
@sywhang

Comments

@abhinav
Copy link
Collaborator

abhinav commented Sep 7, 2021 •
edited

Per #999, it appears that Zap, or at least zap.Config does not yet support Windows.
I suspect that besides filepath munging, we should work on WIndows just fine.
Opening this to track fixing this.

Ref #994
Ref GO-859
@sywhang sywhang self-assigned this Sep 9, 2021
@abhinav abhinav mentioned this issue Sep 10, 2021
Draft
@abhinav abhinav mentioned this issue Dec 7, 2021
Open
@prashantv prashantv mentioned this issue Aug 25, 2022
Merged
abhinav pushed a commit that referenced this issue Sep 12, 2022
@prashantv
Open absolute paths as files, limited Windows support (#1159)
7cabba7 
Ref #994, #1000

Alternate approach to #999, this approach brings absolute path support
to Windows.
It does so by checking for absolute paths and handling them using the
file factory directly.

To test different paths without trying to actually open them (UNC paths
hit the network), this change also
prefactors the sink registry into a separate type that allows stubbing
of the `os.OpenFile` call.

Note: This change does not bring full Windows support -- many tests
still fail, and Windows file URIs don't work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sywhang sywhang

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abhinav @sywhang