Support concurrent logging to a single WriteSyncer #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the WriteSyncer assumes the underlying Writer will support concurrent Writes correctly. However, this is not true for common io.Writer implementations: - *os.File may call the write syscall multiple times - *bytes.Buffer does not support concurrent writes at all Instead, we will wrap all passed in WriteSyncers in a lockedWriteSyncer which will use a mutex to serialize calls to the underlying WriteSyncer. In future, we may want to expose a way of setting a WriteSyncer that already supports concurrent calls, but since most common implementations cannot handle concurrent writes correctly, locking the writer seems like a simpler default.
| }) | ||
| } | ||
|
|
||
| func runNTimes(n int, wg *sync.WaitGroup, f func()) { |
There was a problem hiding this comment.
Is it worth capturing the full pattern you're using? This helper could easily be runNTimes(n numGoroutines, m iterationsPerGoroutine, wg *sync.WaitGroup, f func()).
There was a problem hiding this comment.
sure, can do that. It's a little less clear to have 2 ints as args, so I added comments for the arguments to make it clearer.
|
Updated with test fix |
prashantv
force-pushed
the
pv_concurrent_write
branch
from
3223491
to
ab8fc4f
Compare
prashantv
force-pushed
the
pv_concurrent_write
branch
from
ab8fc4f
to
9d327a5
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the WriteSyncer assumes the underlying Writer will support
concurrent Writes correctly. However, this is not true for common
io.Writer implementations:
Instead, we will wrap all passed in WriteSyncers in a lockedWriteSyncer
which will use a mutex to serialize calls to the underlying WriteSyncer.
In future, we may want to expose a way of setting a WriteSyncer that
already supports concurrent calls, but since most common implementations
cannot handle concurrent writes correctly, locking the writer seems like
a simpler default.
Fixes #99