[v1, 2/8] Export the Encoder type #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since zap's logger is now strongly separated from its encoders, we need to export the encoder type so users can construct loggers.
| // safe for concurrent use. | ||
| type encoder interface { | ||
| type Encoder interface { |
There was a problem hiding this comment.
If we are exporting this, let's add comments on the below methods, especially Clone/Free since we're expecting the implementors to do the pooling.
There was a problem hiding this comment.
That's covered in PR 8/8, if that's okay.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export the Encoder type, since we'd like to allow external implementations. (Exporting a constructor for the JSON encoder comes in the next PR.)
This is the second of eight PRs to finish up the large pre-v1.0.0 refactoring:
NewLoggerconstructor and removeNewJSONStubTimeEncoder.AddFields(since we already haveField.AddTo)The remaining items in the v1 milestone shouldn't require large-scale changes.