Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant arg from logln #1136

merged 1 commit into from Jul 22, 2022

chore: remove redundant arg from logln #1136

merged 1 commit into from Jul 22, 2022


Copy link

No description provided.

Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #1136 (05a84cf) into master (e3a10fc) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1136      +/-   ##
+ Coverage   98.23%   98.32%   +0.09%     
  Files          49       49              
  Lines        2147     2147              
+ Hits         2109     2111       +2     
+ Misses         29       28       -1     
+ Partials        9        8       -1     
Impacted Files Coverage Δ
sugar.go 100.00% <100.00%> (ø)
zapcore/sampler.go 100.00% <0.00%> (+3.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@abhinav abhinav merged commit d6ce3b9 into uber-go:master Jul 22, 2022
@sashamelentyev sashamelentyev deleted the chore/logln branch July 23, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants