Sort benchmarks in readme by time #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peter-edge, thanks for your PR! By analyzing the history of the files in this pull request, we identified @akshayjshah, @chapsuk and @eklitzke to be potential reviewers. |
|
Oh wow...ya I used a go 1.8 specific feature (sort.Slice), need to fix that. |
akshayjshah
approved these changes
Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sorts the benchmarks in the readme by time. It also adds a
benchmarkRowstruct that is parsed from the benchmark output to add some semantic representation to a benchmark row, which will make it easier to do such things in the future and/or make this into a more general tool.