Add APIs to support buffering #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akshayjshah, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jcorbin, @prashantv and @akabos to be potential reviewers. |
This is a breaking change that adds a `Sync` method to `zapcore.Core`. The intention here is to expose `Sync` all the way up to the loggers themselves; this lets implementations buffer I/O, since the end user can `Sync` at the end of main. (Of course, nothing can save users if they directly panic or os.Exit from a different goroutine.)
prashantv
approved these changes
Mar 10, 2017
|
Given that we frequently are writing docs like "Sync flushes..." perhaps the better name here would've indeed been |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change that adds a
Syncmethod tozapcore.Core. Theintention here is to expose
Syncall the way up to the loggers themselves;this lets implementations buffer I/O, since the end user can
Syncat the endof main.
(Of course, nothing can save users if they directly panic or os.Exit from a
different goroutine.)
This fixes #355.