Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing newline in IncreaseLevel error messages #828

Merged
merged 3 commits into from May 7, 2020

Conversation

SteelPhase
Copy link
Contributor

closes #827

@CLAassistant
Copy link

CLAassistant commented May 1, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #828 into master will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #828      +/-   ##
==========================================
- Coverage   98.33%   98.25%   -0.09%     
==========================================
  Files          43       43              
  Lines        2347     2347              
==========================================
- Hits         2308     2306       -2     
- Misses         32       33       +1     
- Partials        7        8       +1     
Impacted Files Coverage Δ
options.go 100.00% <100.00%> (ø)
zapcore/sampler.go 96.87% <0.00%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feeb9a0...e19f8d3. Read the comment docs.

@prashantv prashantv changed the title Add missing new line Fix missing newline in IncreaseLevel error messages May 7, 2020
@prashantv prashantv merged commit c9ca999 into uber-go:master May 7, 2020
3 checks passed
uvfive pushed a commit to bxsmart/zap that referenced this pull request May 21, 2020
cgxxv pushed a commit to cgxxv/zap that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Missing new line on fmt Fprintf
3 participants