Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document when ObjectMarshaler and ArrayMarshaler are used #837

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

prashantv
Copy link
Collaborator

Fixes #836

@prashantv prashantv requested a review from abhinav June 11, 2020 02:56
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #837 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #837   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          43       43           
  Lines        2349     2349           
=======================================
  Hits         2310     2310           
  Misses         32       32           
  Partials        7        7           
Impacted Files Coverage Δ
zapcore/marshaler.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3640f92...f417d90. Read the comment docs.

@prashantv prashantv merged commit 39aa3a1 into master Jun 11, 2020
@prashantv prashantv deleted the docs_marshal branch June 11, 2020 18:01
cgxxv pushed a commit to cgxxv/zap that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

MarshalLogObject is not respected when nested
3 participants