Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newFileSink: use normatve 0666 default perm to OpenFile #862

Merged
merged 1 commit into from Sep 1, 2020

Conversation

jcorbin
Copy link
Contributor

@jcorbin jcorbin commented Sep 1, 2020

Addresses a minor wart discussed in #860

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@prashantv prashantv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

abhinav
abhinav approved these changes Sep 1, 2020
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #862 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #862   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files          43       43           
  Lines        2390     2390           
=======================================
  Hits         2351     2351           
  Misses         32       32           
  Partials        7        7           
Impacted Files Coverage Δ
sink.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 217b2cb...8a41767. Read the comment docs.

@prashantv prashantv merged commit d0a4b9e into uber-go:master Sep 1, 2020
1 check passed
@jcorbin jcorbin deleted the file_perms branch September 1, 2020 23:35
cgxxv pushed a commit to cgxxv/zap that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants