Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FilterFieldKey to zaptest/observer #928

Merged
merged 1 commit into from Mar 23, 2021

Conversation

@r-hang
Copy link
Contributor

@r-hang r-hang commented Mar 16, 2021

Adds functionality to filter zap.Field by key. This makes testing for
field existence regardless of value more convenient.

resolves #816

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Mar 16, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

@codecov codecov bot commented Mar 16, 2021

Codecov Report

Merging #928 (d5cc7f5) into master (89e3820) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #928   +/-   ##
=======================================
  Coverage   98.26%   98.27%           
=======================================
  Files          44       44           
  Lines        1965     1969    +4     
=======================================
+ Hits         1931     1935    +4     
  Misses         27       27           
  Partials        7        7           
Impacted Files Coverage Δ
zaptest/observer/observer.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e3820...d5cc7f5. Read the comment docs.

@prashantv prashantv requested a review from abhinav Mar 22, 2021
@r-hang r-hang force-pushed the r-hang:rhang/filter-field-key branch from 855526f to fab73a8 Mar 22, 2021
Adds functionality to filter zap.Field by key. This makes testing for
field existence regardless of value more convenient.

resolves #816
@r-hang r-hang force-pushed the r-hang:rhang/filter-field-key branch from fab73a8 to d5cc7f5 Mar 22, 2021
@r-hang r-hang merged commit bfa147a into uber-go:master Mar 23, 2021
4 checks passed
4 checks passed
@travis-ci
Travis CI - Pull Request Build Passed
Details
@codecov
codecov/patch 100.00% of diff hit (target 98.26%)
Details
@codecov
codecov/project 98.27% (target 95.00%)
Details
license/cla Contributor License Agreement is signed.
Details
@r-hang r-hang deleted the r-hang:rhang/filter-field-key branch Mar 23, 2021
abhinav added a commit that referenced this pull request May 25, 2021
Adds functionality to filter zap.Field by key. This makes testing for
field existence regardless of value more convenient.

resolves #816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

5 participants