clock: Move to zapcore #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to export the Clock interface from the top-level Zap package. This is a low-level API so we can keep it in zapcore only.
Codecov Report
@@ Coverage Diff @@
## master #950 +/- ##
==========================================
- Coverage 98.12% 98.02% -0.11%
==========================================
Files 44 44
Lines 1975 1975
==========================================
- Hits 1938 1936 -2
- Misses 29 30 +1
- Partials 8 9 +1
Continue to review full report at Codecov.
|
Merged
abhinav
added a commit
that referenced
this pull request
May 25, 2021
This release v1.17.0 of Zap with all changes from `master` minus the following: - #897 - #948 - #950 These changes were omitted because we're still in the process of changing the interface introduced in #897. We will include that in the next release. Release changelog: https://github.com/uber-go/zap/blob/release-1-17/CHANGELOG.md#1170-25-may-2021 Using [apidiff], the surface area of this release compared to v1.16.0 is: ``` --- go.uber.org/zap --- Compatible changes: - Inline: added --- go.uber.org/zap/zapcore --- Compatible changes: - InlineMarshalerType: added --- go.uber.org/zap/zapgrpc --- Compatible changes: - (*Logger).Error: added - (*Logger).Errorf: added - (*Logger).Errorln: added - (*Logger).Info: added - (*Logger).Infof: added - (*Logger).Infoln: added - (*Logger).V: added - (*Logger).Warning: added - (*Logger).Warningf: added - (*Logger).Warningln: added --- go.uber.org/zap/zaptest/observer --- Compatible changes: - (*ObservedLogs).FilterFieldKey: added ``` [apidiff]: https://github.com/golang/exp/blob/master/apidiff/README.md Resolves #942 Refs GO-599
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to export the Clock interface from the top-level Zap
package. This is a low-level API so we can keep it in zapcore only.