This repository has been archived by the owner on Sep 25, 2020. It is now read-only.
Allow multiple checksums #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mennopruijssers
commented
Dec 6, 2016
| @@ -115,6 +115,14 @@ | |||
| "checksum": { | |||
| "type": "number" | |||
| }, | |||
| "checksums": { | |||
There was a problem hiding this comment.
Since ringpop-node doesn't support it yet, checksums is not added to the list with required properties.
dansimau
reviewed
Dec 7, 2016
| "type": "object", | ||
| "patternProperties": { | ||
| "^.*$": { | ||
| "type": "number" |
There was a problem hiding this comment.
A checksum is always a number?
There was a problem hiding this comment.
For now yes (and I don't see any reason to change it in the future)
There was a problem hiding this comment.
The result of a farmhash is always a number. That's the bit I was missing (I thought it was alphanumeric). Cool, thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uber/ringpop-go#192 adds support for multiple checksums. This PR makes the required changes to the protocol schema.