This repository has been archived by the owner on Sep 25, 2020. It is now read-only.
Make sure incarnation number is increased when bumped #298
Comments
mennopruijssers
pushed a commit
that referenced
this issue
Aug 3, 2016
This commit adds support for labels to the local membership. To make testing cleaner/easier, I extended the `testRingpop`-function to support subtests and testing on a ringpop that isn't ready yet. I also had to add a private function - `_newIncarnationNumber` - to `Membership` to generate a new incarnation number. Otherwise the tests were flaky because of the issue descibred in #298. Note: labels are not yet gossiped. I will add that in a separate PR.
mennopruijssers
pushed a commit
that referenced
this issue
Jan 27, 2017
This commit adds support for labels to the local membership. To make testing cleaner/easier, I extended the `testRingpop`-function to support subtests and testing on a ringpop that isn't ready yet. I also had to add a private function - `_newIncarnationNumber` - to `Membership` to generate a new incarnation number. Otherwise the tests were flaky because of the issue descibred in #298. Note: labels are not yet gossiped. I will add that in a separate PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When reincarnating, the incarnation number is always "bumped" to the current time in ms. If we reincarnate twice in one ms, the incarnation number is not really bumped.
By can make sure it's always increasing by using
max(currentIncarnationNumber + 1, Date.now()).(go: uber/ringpop-go#163)
The text was updated successfully, but these errors were encountered: