chore: remove redundant conditional expressions and consistently use …

…!! (#1228)

.babelrc.js

@@ -1,6 +1,5 @@
 const {BABEL_ENV} = process.env;
-const modules =
-  BABEL_ENV === 'es' || BABEL_ENV === 'modules' ? false : 'commonjs';
+const modules = !(BABEL_ENV === 'es' || BABEL_ENV === 'modules') && 'commonjs';
 
 module.exports = {
   presets: [

documentation-site/static/examples/modal/basic.js

@@ -17,7 +17,7 @@ class ModalStateContainer extends React.Component {
   };
   toggle = (open = !this.state.isOpen) => {
     this.setState({
-      isOpen: Boolean(open),
+      isOpen: !!open,
     });
   };
   open = () => {

jest-puppeteer.config.js

@@ -11,7 +11,7 @@ LICENSE file in the root directory of this source tree.
 let headless = true;
 
 if (process.env.PUPPETEER_HEADLESS) {
-  headless = process.env.PUPPETEER_HEADLESS === 'false' ? false : true;
+  headless = process.env.PUPPETEER_HEADLESS !== 'false';
 }
 
 module.exports = {

src/button-group/button-group.js

@@ -70,7 +70,7 @@ export function ButtonGroupRoot(props: {|...PropsT, ...LocaleT|}) {
         }
 
         return React.cloneElement(child, {
-          disabled: props.disabled ? true : child.props.disabled,
+          disabled: props.disabled || child.props.disabled,
           isSelected: isSelected(props.selected, index),
           kind: KIND.tertiary,
           onClick: event => {

src/card/card.js

@@ -22,7 +22,7 @@ import {
 import type {CardsPropsT} from './types.js';
 
 export function hasThumbnail(props: {+thumbnail?: string}) {
-  return Boolean(props.thumbnail);
+  return !!props.thumbnail;
 }
 
 function Card(props: CardsPropsT) {

src/datepicker/day.js

@@ -153,14 +153,13 @@ export default class Day extends React.Component<DayPropsT, DayStateT> {
     const {date, value, highlightedDate, range, highlighted} = this.props;
     const $isHighlighted = highlighted;
     const $selected = this.isSelected();
-    const $hasRangeHighlighted =
+    const $hasRangeHighlighted = !!(
       Array.isArray(value) &&
       range &&
       value.length === 1 &&
       highlightedDate &&
       !isSameDay(value[0], highlightedDate)
-        ? true
-        : false;
+    );
     return {
       $date: date,
       $disabled: this.props.disabled,

src/modal/__tests__/modal.scenario.js

@@ -46,7 +46,7 @@ class ModalStateContainer extends React.Component<
   };
   toggle = (open?: boolean = !this.state.isOpen) => {
     this.setState({
-      isOpen: Boolean(open),
+      isOpen: !!open,
     });
   };
   open = () => {

src/modal/modal.js

@@ -218,10 +218,10 @@ class Modal extends React.Component<ModalPropsT, ModalStateT> {
     return {
       $animate: animate,
       $isVisible: this.state.isVisible,
-      $isOpen: Boolean(isOpen),
+      $isOpen: !!isOpen,
       $size: size,
       $role: role,
-      $closeable: Boolean(closeable),
+      $closeable: !!closeable,
     };
   }
 

src/popover/popover.js

@@ -350,7 +350,7 @@ class Popover extends React.Component<PopoverPropsT, PopoverPrivateStateT> {
     const {isOpen, showArrow} = this.props;
     const {isAnimating, arrowOffset, popoverOffset, placement} = this.state;
     return {
-      $showArrow: Boolean(showArrow),
+      $showArrow: !!showArrow,
       $arrowOffset: arrowOffset,
       $popoverOffset: popoverOffset,
       $placement: placement,

src/select/select.js

@@ -223,7 +223,7 @@ class Select extends React.Component<PropsT, SelectStateT> {
       if (this.input) this.input.value = '';
 
       this.setState(prev => ({
-        isOpen: this.focusAfterClear ? false : !prev.isOpen,
+        isOpen: !this.focusAfterClear && !prev.isOpen,
         isPseudoFocused: false,
       }));
 
@@ -255,7 +255,7 @@ class Select extends React.Component<PropsT, SelectStateT> {
 
     let toOpen = this.state.isOpen || this.openAfterFocus;
     // if focus happens after clear values, don't open dropdown yet.
-    toOpen = this.focusAfterClear ? false : toOpen;
+    toOpen = !this.focusAfterClear && toOpen;
 
     this.setState({
       isFocused: true,

src/side-navigation/nav.js

@@ -25,9 +25,7 @@ export default class SideNav extends React.Component<NavPropsT> {
     renderItem: null,
   };
 
-  activePredicate = (item: Item) => {
-    return item.itemId === this.props.activeItemId ? true : false;
-  };
+  activePredicate = (item: Item) => item.itemId === this.props.activeItemId;
 
   render() {
     const {