-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(accordion): update focus highlight #1401
Conversation
d2e598a
to
2be2f84
Compare
Sure |
@gergelyke Thank you for your time. I see that the screener check was failed again. Can you provide from where regression coming, because I check storybook and it seems that stories don't have regression. Maybe I miss something? |
it's specifically when running IE 11 |
0275b00
to
0301d0b
Compare
It's very strange that build was failed. |
thanks for the contribution @qqingvarqq 👏 |
Fixes #1323
Description
Removed position relative because it changes stacking, which causes to hiding focus highlight at the bottom, as described in the linked issue.
This fix also fixes inconsistent with 'outlining content', when we add overrides, because
outline: 2px solid #F6BA8B;
is outside box model that's mean that we should show full outlining or hide them completely.(It's from the documentation site https://baseweb.design/components/accordion/#overrides)
Before:
After:
If you need to hide all content even outside the box-model I can make appropriate changes for that.
Scope