Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es6 build: stricter targets to eliminate async/await transformations #240

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Sep 9, 2019

The current set of targets include too many transforms. In particular, async/await gets transformed and generator runtime gets included which completely defeats the clean async debugging experience in Chrome.

At this point, the goal is to get rid of

  transform-async-to-generator { "ios":"10.3", "safari":"10.1" }

As can be seen, additional plugin reduction will not be possible until end of year when Node 8 ends LTS.

After the change the following plugins are picked:

  transform-template-literals { "ios":"12", "safari":"12" }
  transform-function-name { "edge":"18" }
  transform-dotall-regex { "edge":"18", "firefox":"60", "node":"8" }
  proposal-async-generator-functions { "edge":"18", "node":"8" }
  proposal-object-rest-spread { "edge":"18", "node":"8" }
  proposal-unicode-property-regex { "edge":"18", "firefox":"60", "node":"8" }
  proposal-json-strings { "chrome":"64", "edge":"18", "firefox":"60", "node":"8" }
  proposal-optional-catch-binding { "chrome":"64", "edge":"18", "node":"8" }
  transform-named-capturing-groups-regex { "edge":"18", "firefox":"60", "node":"8" }

Before the change

  transform-template-literals { "ios":"10.3", "safari":"10.1" }
  transform-function-name { "edge":"15" }
  transform-dotall-regex { "chrome":"60", "edge":"15", "firefox":"53", "ios":"10.3", "node":"8", "safari":"10.1" }
  transform-unicode-regex { "ios":"10.3", "safari":"10.1" }
  transform-parameters { "edge":"15" }
  transform-async-to-generator { "ios":"10.3", "safari":"10.1" }
  proposal-async-generator-functions { "chrome":"60", "edge":"15", "firefox":"53", "ios":"10.3", "node":"8", "safari":"10.1" }
  proposal-object-rest-spread { "edge":"15", "firefox":"53", "ios":"10.3", "node":"8", "safari":"10.1" }
  proposal-unicode-property-regex { "chrome":"60", "edge":"15", "firefox":"53", "ios":"10.3", "node":"8", "safari":"10.1" }
  proposal-json-strings { "chrome":"60", "edge":"15", "firefox":"53", "ios":"10.3", "node":"8", "safari":"10.1" }
  proposal-optional-catch-binding { "chrome":"60", "edge":"15", "firefox":"53", "ios":"10.3", "node":"8", "safari":"10.1" }
  transform-named-capturing-groups-regex { "chrome":"60", "edge":"15", "firefox":"53", "ios":"10.3", "node":"8", "safari":"10.1" }

@ibgreen ibgreen merged commit a4cb466 into master Sep 9, 2019
@ibgreen ibgreen deleted the ib/es6-targets branch September 9, 2019 19:26
@ibgreen
Copy link
Collaborator Author

ibgreen commented Sep 9, 2019

0.0.28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants