Better support for jsRoutes #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in jsRoutes. Previously, jsRoutes was taken as is - there was no reprocessing at all. All routes that needed to appear in the table of contents had to be in mdRoutes. The issue there is that mdRoutes mixed 2 kind of routes - those with documentations (as intended) and those with standalone components. With this PR, we can go back to a model where mdRoutes contains only routes with markdown files (and can easily be generated instead of manually created)
|
(nb - this will be required for visgl/luma.gl#583) |
ibgreen
approved these changes
Aug 7, 2018
jckr
added a commit
that referenced
this pull request
Aug 8, 2018
* add build sitemaps script * regenerated docs * Add files via upload * Add files via upload * Delete google319a4ae362a3a60e.html * Add files via upload * avoid scss variable if it doesnt exist (#54) * can now pass path for automatic docs route generation (#57) * This diff support creation of tables of content for routes described in jsRoutes. (#56) Previously, jsRoutes was taken as is - there was no reprocessing at all. All routes that needed to appear in the table of contents had to be in mdRoutes. The issue there is that mdRoutes mixed 2 kind of routes - those with documentations (as intended) and those with standalone components. With this PR, we can go back to a model where mdRoutes contains only routes with markdown files (and can easily be generated instead of manually created) * add build sitemaps script * regenerated docs * update sitemap syntax * before rebasing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, jsRoutes was taken as is - there was no reprocessing at all.
All routes that needed to appear in the table of contents had to be in mdRoutes.
The issue there is that mdRoutes mixed 2 kind of routes - those with documentations (as intended) and those with standalone components.
With this PR, we can go back to a model where mdRoutes contains only routes with markdown files (and can easily be generated instead of manually curated)