Change default enabled
behavior of Log class
#115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enabled
flag is practically meaningless (can just be replaced withlog.level = 0
).new Log().log('hello')()
would actually log something to the console. Currently log instances are disabled by default.log.enable(true).setLevel(1)
just to see some logs.In both deck.gl and luma.gl, the log objects are enabled on initialization, e.g. https://github.com/uber/deck.gl/blob/7.3-release/modules/core/src/utils/log.js#L3
Therefore changing the default here does not affect the default behavior in our primary use cases.