Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not handle thrift files with flow-protected keywords as the file name #88

Open
boconnell opened this issue Jul 11, 2019 · 0 comments

Comments

@boconnell
Copy link

Problem:
For example, if a file foo.thrift imports the file any.thrift and tries to references one of any.thrifts exports, the generated flow code will ultimately look like:

foo.js:

import any from './any';

type bar = {
  a: any.baz,
}

at which point flow will report an error because it doesn't expect a . after the keyword any. I imagine this might happen with other file names that are flow-protected keywords.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant