Clean up annotations #208
Merged
Clean up annotations #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up a few annotations areas for a few reasons. - Switch to internal `DoNotMock` annotation, as error-prone removed theirs. We're leaving in our own annotation for documentation purposes and any custom error prone checks that still look for annotations with this name. - Remove javaxextras for compatibility with the Java 9 module system, which unfortunately JSR 305 is not compatible with. - Remove stale jsr305 dependency.
kageiit
approved these changes
May 7, 2018
msridhar
approved these changes
May 7, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up a few annotations areas for a few reasons.
DoNotMockannotation, as error-prone removed theirs. We're leaving in our own annotation for documentation purposes and any custom error prone checks that still look for annotations with this name.