Removed synthentic accessor from auto disposables and recording observer

[bangarharshit]

Removed synthetic accessors. Fixes - #102
Total dex count

• autodispose package: Master - 454, New - 449,
• recording observer - Master - 49, New - 42

[CLAassistant]

All committers have signed the CLA.

[ZacSweers]

This seems fine to me. Mind adding a comment on those methods to indicate that they're normally private but made package-local for the accessors?

Just adding something like an inline /* private */ might be enough context for now. I've proposed an annotation in error-prone for enforcement of this - google/error-prone#765

[bangarharshit]

Added comments to indicate the scope.

[bangarharshit]

Making it inline.

[ZacSweers]

Make sure you sign the correct CLA, it seems you're committing from a different github account

[bangarharshit]

Fixed the account for commit.

[ZacSweers]

Thanks! I wonder if we can have a tool automate checking this.

Also in the future, mind keeping follow-up commits separate rather than squashing? Makes it easier to review follow-ups in isolation.

[bangarharshit]

Sure. Will take care of it.

IntelliJ provides inspection for these but yeah some kind of error-prone check on CI will be great. Maybe a custom checker if the repo supports that.