Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Kotlin 1.3.20! #329

Merged
merged 2 commits into from Jan 24, 2019
Merged

Upgrade to Kotlin 1.3.20! #329

merged 2 commits into from Jan 24, 2019

Conversation

ShaishavGandhi
Copy link
Collaborator

@ShaishavGandhi ShaishavGandhi commented Jan 23, 2019

Faster builds with this one!

./gradlew clean check previously took 1m 32s. Down to 52-53s.
Had to disable the parallel build. It caused connectedTests to fail.

@ZacSweers
Copy link
Collaborator

Interesting. Any chance you could take a before/after build scan?

Copy link
Collaborator

@ZacSweers ZacSweers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I see now it's because of the parallelization. Interesting that it makes a difference here since I thought we had all single-source-set projects

@ShaishavGandhi
Copy link
Collaborator Author

Yeah it's mainly because of parallelization of Gradle.

@ShaishavGandhi
Copy link
Collaborator Author

The parallel thing didn't sit well with the connected tests.

@ShaishavGandhi ShaishavGandhi merged commit 2146aa8 into master Jan 24, 2019
@ShaishavGandhi ShaishavGandhi deleted the sg/kotlin-1320 branch January 24, 2019 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants