Move Kotlin extension functions to main artifact #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This preserves binary compatibility by using a different file name at the jvm level (`KotlinExtensions`) while adopting the Retrofit-style approach of making the kotlin extensions directly available and making the stdlib dep optional
by marking these hidden, should make the new ones "just work" for consumers since the imports are the same
jbarr21
approved these changes
Apr 4, 2019
ShaishavGandhi
approved these changes
Apr 4, 2019
autodispose/src/main/java/com/uber/autodispose/KotlinExtensions.kt
Outdated
Show resolved
Hide resolved
autodispose/src/test/java/com/uber/autodispose/AutoDisposeKotlinTest.kt
Outdated
Show resolved
Hide resolved
|
I forgot about intrinsics. Let's just make it |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This preserves binary compatibility by using a different file name at the jvm level (
KotlinExtensions) while adopting the Retrofit-style approach of making the kotlin extensions directly available and making the stdlib dep optional.This also marks the existing -ktx version as deprecated with
HIDDENseverity. This makes this basically seamless for consumers where the imports are unchanged.If this looks good, we can make passes to move the other ktx functions too