-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to RxJava 3 #381
Merged
Migrate to RxJava 3 #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until there is an rxjava3-compatible rxlifecycle
We'll want a 2.x and 1.x branch right? So that we can keep supporting both RxJava2 and RxJava3 if there are any bug fixes. |
Nope, I don't think that's necessary. We can backport bugfixes via branch
based on the last 1.x tag. RxJava did this because of a long tail of
concurrent maintenance and development, but we're not going to develop 1.x
any further.
…On Thu, Sep 19, 2019 at 12:04 AM Shaishav Gandhi ***@***.***> wrote:
We'll want a 2.x and 1.x branch right? So that we can keep supporting both
RxJava2 and RxJava3 if there are any bug fixes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#381?email_source=notifications&email_token=AAKMJPURRZTI3NIMDZ5HOCTQKL23NA5CNFSM4IYDU6Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7CEIWY#issuecomment-532956251>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKMJPTXYDKY2447XJ2K3XLQKL23NANCNFSM4IYDU6QQ>
.
|
ShaishavGandhi
approved these changes
Sep 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package name and maven coords change in followup?
Yep one step at a time
…On Thu, Sep 19, 2019 at 7:03 AM Shaishav Gandhi ***@***.***> wrote:
***@***.**** approved this pull request.
Package name and maven coords change in followup?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#381?email_source=notifications&email_token=AAKMJPSG6WUR64QKT76BHHDQKNL7TA5CNFSM4IYDU6Q2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFIHRGY#pullrequestreview-290486427>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKMJPQSKJJIT2AIXE2XQUTQKNL7TANCNFSM4IYDU6QQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #359