TestScopeProvider + build fixes #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonycosentini
suggested changes
Mar 13, 2017
| * | ||
| * @param o the object to emit. | ||
| */ | ||
| public void emit(Object o) { |
There was a problem hiding this comment.
Is there ever a case where it matters what value is being emitted?
IMO there isn't a good use case for this API.
| /** | ||
| * Emits an error event, just a simple RuntimeException. | ||
| */ | ||
| public void emitError() { |
There was a problem hiding this comment.
I think both of the error APIs aren't super useful - it almost suggests that you should test a broken ScopeProvider.
Thoughts?
There was a problem hiding this comment.
We do cover the error case in autodispose, and error in this case doesn't necessarily imply broken. I'll remove for now though to have symmetry with the other test scope provider, can revisit if anyone asks for it
There was a problem hiding this comment.
Interesting, in my mind an observable that emits only lifecycle events should never really error.
Also not really necessary
|
Removed |
tonycosentini
approved these changes
Mar 13, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces
TestScopeProvider+ fixes some build issues