Skip to content

Commit

Permalink
Update to Error Prone 2.20.0 (#772)
Browse files Browse the repository at this point in the history
Pretty straightforward update
  • Loading branch information
msridhar committed Jun 23, 2023
1 parent a81c4b3 commit 18b6ab3
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,16 @@ jobs:
epVersion: 2.4.0
- os: macos-latest
java: 11
epVersion: 2.19.1
epVersion: 2.20.0
- os: ubuntu-latest
java: 11
epVersion: 2.19.1
epVersion: 2.20.0
- os: windows-latest
java: 11
epVersion: 2.19.1
epVersion: 2.20.0
- os: ubuntu-latest
java: 17
epVersion: 2.19.1
epVersion: 2.20.0
fail-fast: false
runs-on: ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -76,7 +76,7 @@ jobs:
with:
arguments: coveralls
continue-on-error: true
if: runner.os == 'Linux' && matrix.java == '11' && matrix.epVersion == '2.19.1' && github.repository == 'uber/NullAway'
if: runner.os == 'Linux' && matrix.java == '11' && matrix.epVersion == '2.20.0' && github.repository == 'uber/NullAway'
- name: Test publishToMavenLocal flow
env:
ORG_GRADLE_PROJECT_epApiVersion: ${{ matrix.epVersion }}
Expand Down
2 changes: 1 addition & 1 deletion gradle/dependencies.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import org.gradle.util.VersionNumber
// The oldest version of Error Prone that we support running on
def oldestErrorProneVersion = "2.4.0"
// Latest released Error Prone version that we've tested with
def latestErrorProneVersion = "2.19.1"
def latestErrorProneVersion = "2.20.0"
// Default to using latest tested Error Prone version, except on Java 8, where 2.10.0 is the last version
// that works
def defaultErrorProneVersion = JavaVersion.current() >= JavaVersion.VERSION_11 ? latestErrorProneVersion : "2.10.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ private void testAnnotationInAarTemplate(
* @param result Map of 'method signatures' to their 'inferred list of NonNull parameters'.
* @param expected Map of 'method signatures' to their 'expected list of NonNull parameters'.
*/
private boolean verify(Map<String, Set<Integer>> result, HashMap<String, Set<Integer>> expected) {
private boolean verify(Map<String, Set<Integer>> result, Map<String, Set<Integer>> expected) {
for (Map.Entry<String, Set<Integer>> entry : result.entrySet()) {
String mtd_sign = entry.getKey();
Set<Integer> ddParams = entry.getValue();
Expand Down

0 comments on commit 18b6ab3

Please sign in to comment.