Skip to content

Commit

Permalink
Merge branch 'test-8-on-11' into wala-update
Browse files Browse the repository at this point in the history
  • Loading branch information
msridhar committed Jul 8, 2023
2 parents a9d6f37 + 6cdfe34 commit f85a081
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions nullaway/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,10 @@ test {

apply plugin: 'com.vanniktech.maven.publish'

// Required on Java 11+ since Error Prone and NullAway access a bunch of
// JDK-internal APIs that are not exposed otherwise
// MS: the below is unnecessary since we are targeting JDK 8. Once we target
// JDK 11, uncomment
// These --add-exports arguments are required when targeting JDK 11+ since Error Prone and NullAway access a bunch of
// JDK-internal APIs that are not exposed otherwise. Since we currently target JDK 8, we do not need to pass the
// arguments, as encapsulation of JDK internals is not enforced on JDK 8. In fact, the arguments cause a compiler error
// when targeting JDK 8. Leaving commented so we can easily add them back once we target JDK 11.
// tasks.withType(JavaCompile).configureEach {
// options.compilerArgs += [
// "--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED",
Expand Down

0 comments on commit f85a081

Please sign in to comment.