Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MethodRef Javadocs wrong for method with multiple arguments (space after comma doesn't work) #972

Closed
robinst opened this issue Jun 6, 2024 · 2 comments · Fixed by #973
Closed

Comments

@robinst
Copy link

robinst commented Jun 6, 2024

Steps to reproduce:

  1. Add a LibraryModels implementation
  2. Implement e.g. the castToNonNullMethods method and return a method ref with a signature like "<T>castToNonNull(T, java.lang.String)" (notice the space after the comma!)

Expected: It works, because the Javadocs example has a comma, see:

* <li>signature is a method name plus argument types, e.g., <code>foo(java.lang.Object,
* java.lang.String)</code>

Actual: The space doesn't make it work. Removing the space makes it work:

-"<T>castToNonNull(T, java.lang.String)"
+"<T>castToNonNull(T,java.lang.String)"

The Javadocs should probably be fixed, or spaces could be removed by methodRef.

@msridhar
Copy link
Collaborator

msridhar commented Jun 7, 2024

Thanks for the report, I've put up #973 to fix the documentation.

msridhar added a commit that referenced this issue Jun 8, 2024
@robinst
Copy link
Author

robinst commented Jun 8, 2024

Perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants