Fix error on checking the initTree2PrevFieldInit cache. #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found it running this tool: https://lgtm.com/projects/g/uber/NullAway/alerts/?mode=list&severity=error It also reports a few issues with closing files in JarInfer code, but it's less obvious to me those are real issues, since it complains whenever streams escape the current method (they might be actual leaks, but it's not as clear cut as this case and I haven't taken any in-depth look yet). |
msridhar
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were saving
ASTHelpers.getSymbol(enclosingClass)(AClassSymbol) but testing forenclosingClassitself (ClassTree). This didn't cause a functional problem, but it means the cache was never being hit.