New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Jar to Jar transformation to JarInfer #316
Conversation
…g that to test annotated classes.
…ode and the corresponding test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of comments because this is lots of code, but overall the approach and code looks good to me.
A few general points:
- Not sure I understand the logic for the source based test cases (the one using a test project I get, just the one involving
getToyTestSrcWithExpectAnnotations
doesn't quite make sense to me. - Please change the PR title and description to something that would make for a useful documenting commit message once we squash and merge. Otherwise we'll be scratching our heads a year from now trying to figure out what
JarInfer (#316)
was ;) - Probably worth adding a few javadocs at the class and public method level
- Also, I just realized this is missing in some other files, but the license information should be at the top of each source files, as in https://github.com/uber/NullAway/blob/master/nullaway/src/main/java/com/uber/nullaway/NullAway.java (will send you the internal guidelines in a moment)
jar-infer/jar-infer-lib/src/test/java/com/uber/nullaway/jarinfer/JarInferTest.java
Outdated
Show resolved
Hide resolved
jar-infer/jar-infer-lib/src/main/java/com/uber/nullaway/jarinfer/BytecodeAnnotator.java
Show resolved
Hide resolved
jar-infer/jar-infer-lib/src/main/java/com/uber/nullaway/jarinfer/BytecodeAnnotator.java
Outdated
Show resolved
Hide resolved
jar-infer/jar-infer-lib/src/main/java/com/uber/nullaway/jarinfer/BytecodeAnnotator.java
Show resolved
Hide resolved
...er/jar-infer-lib/src/main/java/com/uber/nullaway/jarinfer/DefinitelyDerefedParamsDriver.java
Show resolved
Hide resolved
jar-infer/jar-infer-lib/src/test/java/com/uber/nullaway/jarinfer/AnnotationComparator.java
Outdated
Show resolved
Hide resolved
jar-infer/jar-infer-lib/src/test/java/com/uber/nullaway/jarinfer/JarInferTest.java
Outdated
Show resolved
Hide resolved
jar-infer/jar-infer-lib/src/test/java/com/uber/nullaway/jarinfer/JarInferTest.java
Outdated
Show resolved
Hide resolved
jar-infer/test-java-lib-jarinfer/src/main/java/com/uber/nullaway/jarinfer/toys/Toys.java
Show resolved
Hide resolved
jar-infer/test-java-lib-jarinfer/src/main/java/com/uber/nullaway/jarinfer/toys/Toys.java
Show resolved
Hide resolved
Thanks for the detailed comments. Addressed them. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a more descriptive title and a quick summary of the top changes maybe to now we changed jarinfer
Summary of changes:
|
Updated the title and added a summary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see comment about missing Javadoc, and also please make sure the title of the commit is under 80 characters (we don't always follow this, but we probably should :), you can still have a longer explanation inside the message body).
Suggestion:
Add support for Jar to Jar transformation to JarInfer
This adds support for annotating jar files, as opposed to creating an
astubx file on the side.
Summary of changes:
...
Followed for the stuff you already have. Once those two are addressed, feel free to land it.
jar-infer/jar-infer-lib/src/test/java/com/uber/nullaway/jarinfer/AnnotationChecker.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a code style comment that probably should be fixed in a follow-up rather than here.
This adds support for annotating jar files, as opposed to creating an astubx file on the side.
Summary of changes: