Allow models to override @Nullable on third-party functional interfaces #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things, one uncontroversial and the other more opinionated
[Uncontroversial] It acknowledges
LibraryModels.nonNullParameters()
when deciding the nullability of the arguments in a lambda with a functional interface which otherwise marks the parameters as@Nullable
. Before we did acknowledge this when calling the FI methods directly, but not for lambda expression based overriding.[Opinionated] We override the nullability of Guava's
Function
andPredicate
functional interfaces. This means that lambdas implementing these in our code will need to return@NonNull
but need not check the incoming arguments.This has implications for checking Guava code with NullAway, but not for treating it as annotated vs unannotated with restrictive annotations enabled.
cc: @kurtisnelson