Improved Map handling: Strings and integers. #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change improves our handling of map operations such as `containsKey`, `put`, and `get`, by allowing keys that do not have an access path directly associated with them. In particular, it allows literal strings to be understood as `Map` keys by NullAway for the purpose of matching checked and accessed map-paths (fixing #398). It also handles boxed integers and long integers, both as literals and as primitive variables (fixing #410).
msridhar
reviewed
Jul 27, 2020
| // No MapKey object can be constructed here | ||
| return null; | ||
| } | ||
| return new AccessPathMapKey(accessPath); |
There was a problem hiding this comment.
Do you think it would be worthwhile to just have AccessPath implement MapKey instead of introducing this AccessPathMapKey wrapper? I don't know what the common case will be here or what the perf impact would be, but that would save one level of indirection for AccessPaths.
There was a problem hiding this comment.
Sounds good to me. It reduces runtime indirection and code size :)
lazaroclapp
commented
Jul 27, 2020
| package com.uber.nullaway.dataflow; | ||
|
|
||
| /** Marker interface to implement a union type of classes that can be used as AccessPath.mapKey */ | ||
| interface MapKey {} |
There was a problem hiding this comment.
This needs to be outside AccessPath.java now to avoid circular definition issues.
This was referenced Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves our handling of map operations such as
containsKey,put, andget, by allowing keys that donot have an access path directly associated with them.
In particular, it allows literal strings to be understood
as
Mapkeys by NullAway for the purpose of matchingchecked and accessed map-paths (fixing #398). It also
handles boxed integers and long integers, both as literals
and as primitive variables (fixing #410).