Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Checker dataflow 3.20.0 #510

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Bump to Checker dataflow 3.20.0 #510

merged 1 commit into from
Dec 7, 2021

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Dec 6, 2021

The key new feature here is that the dataflow library no longer crashes on switch expressions / arrow case labels in switch statements:

https://github.com/typetools/checker-framework/blob/checker-framework-3.20.0/docs/CHANGELOG.md#version-3200-december-6-2021

This is an initial step toward fixing #289, though we will need precise control-flow graphs (which is still a WIP in Checker dataflow) to really handle these constructs properly.

@coveralls
Copy link

Pull Request Test Coverage Report for Build #590

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.402%

Totals Coverage Status
Change from base Build #589: 0.0%
Covered Lines: 3602
Relevant Lines: 4029

💛 - Coveralls

@msridhar
Copy link
Collaborator Author

msridhar commented Dec 7, 2021

JMH Results. Before:

Benchmark                      Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile  thrpt   25  17.281 ± 0.092  ops/s
CaffeineBenchmark.compile     thrpt   25   4.253 ± 0.028  ops/s

After:

Benchmark                      Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile  thrpt   25  17.439 ± 0.088  ops/s
CaffeineBenchmark.compile     thrpt   25   4.255 ± 0.017  ops/s

@msridhar msridhar marked this pull request as ready for review December 7, 2021 05:28
@msridhar msridhar enabled auto-merge (squash) December 7, 2021 05:29
@msridhar msridhar enabled auto-merge (squash) December 7, 2021 05:30
Copy link
Collaborator

@lazaroclapp lazaroclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msridhar msridhar merged commit f98fb3f into master Dec 7, 2021
@msridhar msridhar deleted the cf-3.20.0 branch December 7, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants